Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(session): change default to 15 minutes [PPS-122] #1040

Merged
merged 6 commits into from
Oct 3, 2022
Merged

feat(session): change default to 15 minutes [PPS-122] #1040

merged 6 commits into from
Oct 3, 2022

Conversation

Avantol13
Copy link
Contributor

New Features

Breaking Changes

  • Default session expiration changed from 30 minutes to 15 minutes to comply with FedRAMP

Bug Fixes

Improvements

Dependency updates

Deployment changes

  • B/c the default session expiration changed from 30 minutes to 15 minutes to comply with FedRAMP, you MUST ensure that an instance that should comply with FedRAMP does NOT override this fence configuration (e.g. it should be 15 minutes) SESSION_TIMEOUT: 900

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@coveralls
Copy link

coveralls commented Sep 6, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 12988

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.907%
Totals Coverage Status
Change from base Build 12903: 0.0%
Covered Lines: 6866
Relevant Lines: 9290
💛 - Coveralls

@Avantol13 Avantol13 changed the title feat(session): change default to 15 minutes feat(session): change default to 15 minutes [PPS-122] Sep 14, 2022
MaribelleHGomez
MaribelleHGomez approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@MaribelleHGomez MaribelleHGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Avantol13 Avantol13 merged commit 2c08859 into master Oct 3, 2022
@Avantol13 Avantol13 deleted the feat/default_session branch October 3, 2022 17:56
This was referenced Oct 4, 2022
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Closed
Merged
This was referenced Oct 11, 2022
Merged
Closed
Merged
Merged
Merged
Merged
This was referenced Dec 6, 2022
Closed
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
This was referenced Dec 13, 2022
Merged
Merged
Closed
This was referenced Jan 27, 2023
Closed
Merged
Merged
This was referenced Feb 3, 2023
Closed
Merged
Closed
Closed
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Feb 19, 2023
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Mar 30, 2023
Merged
@github-actions github-actions bot mentioned this pull request Nov 2, 2023
Merged
This was referenced Dec 12, 2023
Merged
Open
Open
Open
Open
@github-actions github-actions bot mentioned this pull request Aug 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaribelleHGomez MaribelleHGomez MaribelleHGomez approved these changes

Assignees
No one assigned
Labels
test-apis-etlTest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Avantol13 @coveralls @MaribelleHGomez @Avantol13-machine-user